[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180508181247.19431-8-mcgrof@kernel.org>
Date: Tue, 8 May 2018 11:12:41 -0700
From: "Luis R. Rodriguez" <mcgrof@...nel.org>
To: gregkh@...uxfoundation.org
Cc: akpm@...ux-foundation.org, keescook@...omium.org,
josh@...htriplett.org, maco@...roid.com, andy.gross@...aro.org,
david.brown@...aro.org, bjorn.andersson@...aro.org, teg@...m.no,
wagi@...om.org, hdegoede@...hat.com, andresx7@...il.com,
zohar@...ux.vnet.ibm.com, kubakici@...pl, shuah@...nel.org,
mfuzzey@...keon.com, dhowells@...hat.com, pali.rohar@...il.com,
tiwai@...e.de, kvalo@...eaurora.org, arend.vanspriel@...adcom.com,
zajec5@...il.com, nbroeking@...com, markivx@...eaurora.org,
broonie@...nel.org, dmitry.torokhov@...il.com, dwmw2@...radead.org,
torvalds@...ux-foundation.org, Abhay_Salunke@...l.com,
jewalt@...innovations.com, oneukum@...e.com,
cantabile.desu@...il.com, ast@...com, hare@...e.com,
jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com, khc@...waw.pl,
davem@...emloft.net, arve@...roid.com, tkjos@...roid.com,
corbet@....net, mchehab+samsung@...nel.org,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, "Luis R. Rodriguez" <mcgrof@...nel.org>
Subject: [PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful
If we resort to using the sysfs fallback mechanism we don't print
the filename. This can be deceiving given we could have a series of
callers intertwined and it'd be unclear exactly for what firmware
this was meant for.
Additionally, although we don't currently use FW_OPT_NO_WARN when
dealing with the fallback mechanism, we will soon, so just respect
its use consistently.
And even if you *don't* want to print always on failure, you may
want to print when debugging so enable dynamic debug print when
FW_OPT_NO_WARN is used.
Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
---
drivers/base/firmware_loader/fallback.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c
index 9169e7b9800c..b676a99c469c 100644
--- a/drivers/base/firmware_loader/fallback.c
+++ b/drivers/base/firmware_loader/fallback.c
@@ -690,6 +690,11 @@ int firmware_fallback_sysfs(struct firmware *fw, const char *name,
if (!fw_run_sysfs_fallback(opt_flags))
return ret;
- dev_warn(device, "Falling back to user helper\n");
+ if (!(opt_flags & FW_OPT_NO_WARN))
+ dev_warn(device, "Falling back to syfs fallback for: %s\n",
+ name);
+ else
+ dev_dbg(device, "Falling back to sysfs fallback for: %s\n",
+ name);
return fw_load_from_user_helper(fw, name, device, opt_flags);
}
--
2.17.0
Powered by blists - more mailing lists