linux-kernel - Re: [PATCH] brd: Mark as non-rotational

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEjAshryoCKbsmdBiB3GMza1LsH_0muREq2Qz4mpbXk4PSaBSg@mail.gmail.com>
Date:   Wed, 09 May 2018 04:07:24 +0000
From:   SeongJae Park <sj38.park@...il.com>
To:     axboe@...nel.dk, dan.j.williams@...el.com, mpatocka@...hat.com
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] brd: Mark as non-rotational

I'm sending this mail for another chance of review.


Thanks,
SeongJae Park
On Thu, May 3, 2018 at 6:53 PM SeongJae Park <sj38.park@...il.com> wrote:

> This commit sets QUEUE_FLAG_NONROT and clears up QUEUE_FLAG_ADD_RANDOM
> to mark the ramdisks as non-rotational device.

> Signed-off-by: SeongJae Park <sj38.park@...il.com>
> ---
>   drivers/block/brd.c | 4 ++++
>   1 file changed, 4 insertions(+)

> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 66cb0f857f64..39c5b90cc187 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -402,6 +402,10 @@ static struct brd_device *brd_alloc(int i)
>          set_capacity(disk, rd_size * 2);
>          disk->queue->backing_dev_info->capabilities |=
BDI_CAP_SYNCHRONOUS_IO;

> +       /* Tell the block layer that this is not a rotational device */
> +       blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
> +       blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue);
> +
>          return brd;

>   out_free_queue:
> --
> 2.13.0