linux-kernel - Re: [PATCH v3 2/5] regulator: add dummy function of_find_regulator_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180509081341.ahx7xuqs366gmqaf@intel.com>
Date:   Wed, 9 May 2018 16:13:42 +0800
From:   "Du, Changbin" <changbin.du@...el.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     changbin.du@...el.com, yamada.masahiro@...ionext.com,
        michal.lkml@...kovi.net, tglx@...utronix.de, mingo@...hat.com,
        akpm@...ux-foundation.org, rostedt@...dmis.org,
        rdunlap@...radead.org, x86@...nel.org, lgirdwood@...il.com,
        arnd@...db.de, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v3 2/5] regulator: add dummy function
 of_find_regulator_by_node

On Wed, May 09, 2018 at 05:21:14PM +0900, Mark Brown wrote:
> On Sun, May 06, 2018 at 08:20:13AM +0800, changbin.du@...el.com wrote:
> > From: Changbin Du <changbin.du@...el.com>
> > 
> > If device tree is not enabled, of_find_regulator_by_node() should have
> > a dummy function since the function call is still there.
> 
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code.  Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.

Hmm, I saw your merging notification too late. Let me refresh the series. Sorry
for confusing.

-- 
Thanks,
Changbin Du