linux-kernel - Re: [PATCH v7 23/24] ASoC: qcom: apq8096: Add db820c machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0db86f6a-76cb-22a5-eed9-98b2134dcb8b@linaro.org>
Date:   Wed, 9 May 2018 11:03:35 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Banajit Goswami <bgoswami@...eaurora.org>, andy.gross@...aro.org,
        broonie@...nel.org, linux-arm-msm@...r.kernel.org,
        alsa-devel@...a-project.org, robh+dt@...nel.org
Cc:     gregkh@...uxfoundation.org, david.brown@...aro.org,
        mark.rutland@....com, lgirdwood@...il.com, plai@...eaurora.org,
        tiwai@...e.com, perex@...ex.cz, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        rohkumar@....qualcomm.com, spatakok@....qualcomm.com
Subject: Re: [PATCH v7 23/24] ASoC: qcom: apq8096: Add db820c machine driver

Thanks for the review Banajit.

On 09/05/18 10:15, Banajit Goswami wrote:
> 
> On 5/1/2018 5:08 AM, Srinivas Kandagatla wrote:
>> This patch adds support to DB820c machine driver.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>>   sound/soc/qcom/Kconfig   |   9 ++
>>   sound/soc/qcom/Makefile  |   2 +
>>   sound/soc/qcom/apq8096.c | 238 
>> +++++++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 249 insertions(+)
>> +    link = card->dai_link;
>> +
>> +    for_each_child_of_node(node, np) {
>> +        cpu = of_get_child_by_name(np, "cpu");
>> +        platform = of_get_child_by_name(np, "platform");
>> +        codec = of_get_child_by_name(np, "codec");
>> +
>> +        if (!cpu) {
>> +            dev_err(dev, "Can't find cpu DT node\n");
> clean up missing to kfree(card->dai_link)?
Yep, I will fix error path in next version.
> 
>> +            return -EINVAL;
>> +        }
>> +
>> +                return ret;
>> +            }
>> +            link->no_pcm = 1;
>> +            link->ignore_suspend = 1;
> ignore_suspend will also need to be set for FE DAIs?
> 
Okay!
>> +            link->ignore_pmdown_time = 1;
>> +            link->be_hw_params_fixup = apq8096_be_hw_params_fixup;
>> +        } else {
>> +            link->platform_of_node = link->cpu_of_node;
>> +            link->codec_dai_name = "snd-soc-dummy-dai";
>> +            link->codec_name = "snd-soc-dummy";
>> +            link->dynamic = 1;
>> +        }

>> +

>> +
>> +static void apq8096_unbind(struct device *dev)
>> +{
>> +    struct snd_soc_card *card = dev_get_drvdata(dev);
>> +
>> +    component_unbind_all(dev, card);
>> +    snd_soc_unregister_card(card);
> Should sound card not be unregistered first, before calling 
> component_unbind_all()?
Yep, I will give that a go.

thanks,
srini

>