linux-kernel - [PATCH v4 2/2] usb: dwc2: fix isoc split in transfer with no data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1525860661-18619-3-git-send-email-william.wu@rock-chips.com>
Date:   Wed,  9 May 2018 18:11:01 +0800
From:   William Wu <william.wu@...k-chips.com>
To:     hminas@...opsys.com, felipe.balbi@...ux.intel.com,
        gregkh@...uxfoundation.org
Cc:     sergei.shtylyov@...entembedded.com, heiko@...ech.de,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, frank.wang@...k-chips.com,
        huangtao@...k-chips.com, dianders@...gle.com,
        daniel.meng@...k-chips.com, John.Youn@...opsys.com,
        william.wu@...k-chips.com, wzz@...k-chips.com, zsq@...k-chips.com,
        Allen.Hsu@...ntatw.com, StanTsui@...EN.com, Spruce.Wu@...ntatw.com,
        Martin.Tsai@...ntatw.com, Kevin.Shai@...ntatw.com,
        Mon-Jer.Wu@...ntatw.com, Claud.Chang@...ntatw.com,
        San.Lin@...ntatw.com, Ren.Kuo@...ntatw.com, davidhtwang@...en.com,
        fonglin@...en.com, stevencheng@...en.com, tomchen@...en.com,
        donchang@...en.com, milesschofield@...en.com
Subject: [PATCH v4 2/2] usb: dwc2: fix isoc split in transfer with no data

If isoc split in transfer with no data (the length of DATA0
packet is zero), we can't simply return immediately. Because
the DATA0 can be the first transaction or the second transaction
for the isoc split in transaction. If the DATA0 packet with no
data is in the first transaction, we can return immediately.
But if the DATA0 packet with no data is in the second transaction
of isoc split in transaction sequence, we need to increase the
qtd->isoc_frame_index and giveback urb to device driver if needed,
otherwise, the MDATA packet will be lost.

A typical test case is that connect the dwc2 controller with an
usb hs Hub (GL852G-12), and plug an usb fs audio device (Plantronics
headset) into the downstream port of Hub. Then use the usb mic
to record, we can find noise when playback.

In the case, the isoc split in transaction sequence like this:

- SSPLIT IN transaction
- CSPLIT IN transaction
  - MDATA packet (176 bytes)
- CSPLIT IN transaction
  - DATA0 packet (0 byte)

This patch use both the length of DATA0 and qtd->isoc_split_offset
to check if the DATA0 is in the second transaction.

Signed-off-by: William Wu <william.wu@...k-chips.com>
---
Changes in v4:
- None

Changes in v3:
- Remove "qtd->isoc_split_offset = 0" in the if test

Changes in v2:
- Modify the commit message

 drivers/usb/dwc2/hcd_intr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
index ba6229e..9751785 100644
--- a/drivers/usb/dwc2/hcd_intr.c
+++ b/drivers/usb/dwc2/hcd_intr.c
@@ -930,9 +930,8 @@ static int dwc2_xfercomp_isoc_split_in(struct dwc2_hsotg *hsotg,
 	frame_desc = &qtd->urb->iso_descs[qtd->isoc_frame_index];
 	len = dwc2_get_actual_xfer_length(hsotg, chan, chnum, qtd,
 					  DWC2_HC_XFER_COMPLETE, NULL);
-	if (!len) {
+	if (!len && !qtd->isoc_split_offset) {
 		qtd->complete_split = 0;
-		qtd->isoc_split_offset = 0;
 		return 0;
 	}

-- 
2.0.0