linux-kernel - Re: [PATCH] selftests: memory-hotplug: delete RUN_TESTS and EMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180509094652.GB10043@localhost.localdomain>
Date:   Wed, 9 May 2018 11:46:52 +0200
From:   Anders Roxell <anders.roxell@...aro.org>
To:     "Shuah Khan (Samsung OSG)" <shuah@...nel.org>
Cc:     lei.yang@...driver.com, po-hsu.lin@...onical.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: memory-hotplug: delete RUN_TESTS and
 EMIT_TESTS overrides

On 2018-05-02 15:18, Shuah Khan (Samsung OSG) wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work after making the change the test to run
> with ratio=2 as the default mode to be able to invoke the test without
> the "-r 2" argument from the common RUN_TESTS and EMIT_TESTS.
> 
> The run_full_tests target now calls the test with "-r 10".
> 
> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@...nel.org>

Reviewed-by: Anders Roxell <anders.roxell@...aro.org>

> ---
>  tools/testing/selftests/memory-hotplug/Makefile           | 5 +----
>  tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 3 ++-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
> index 686da510f989..e0a625e34f40 100644
> --- a/tools/testing/selftests/memory-hotplug/Makefile
> +++ b/tools/testing/selftests/memory-hotplug/Makefile
> @@ -4,11 +4,8 @@ all:
>  include ../lib.mk
>  
>  TEST_PROGS := mem-on-off-test.sh
> -override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
> -
> -override EMIT_TESTS := echo "$(subst @,,$(RUN_TESTS))"
>  
>  run_full_test:
> -	@/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
> +	@/bin/bash ./mem-on-off-test.sh -r 10 && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
>  
>  clean:
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index ae2c790d0880..ff4991704d07 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -133,7 +133,8 @@ offline_memory_expect_fail()
>  
>  error=-12
>  priority=0
> -ratio=10
> +# Run with default of ratio=2 for Kselftest run
> +ratio=2
>  retval=0
>  
>  while getopts e:hp:r: opt; do
> -- 
> 2.14.1
>