linux-kernel - Re: [RFC] sched: Distinguish between idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64ec7411-8d88-5531-72e2-8ac69f163b76@oracle.com>
Date:   Wed, 9 May 2018 09:34:57 -0700
From:   Rohit Jain <rohit.k.jain@...cle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     matt@...eblueprint.co.uk, mingo@...nel.org,
        dhaval.giani@...cle.com, subhra.mazumdar@...cle.com,
        steven.sistare@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC] sched: Distinguish between idle_cpu calls based on desired
 effect

Hi Peter,


On 05/09/2018 01:51 AM, Peter Zijlstra wrote:
> On Mon, May 07, 2018 at 04:41:17PM -0700, Rohit Jain wrote:
>> In commit 247f2f6f3c706b40b5f3886646f3eb53671258bf we distinguish
>> between idle_cpu when the vcpu is not running for scheduling threads.
>> However, idle_cpu function is used at other places for actually checking
>> whether the state of the CPU is idle or not. Hence splitting the use of
>> that function based on the desired return value.
> Yes, that looks OK.

Great! Let me change the comment and send out v2.

>
> for your gitconfig:
>
> [core]
> 	abbrev = 12
> [alias]
>          one = show -s --pretty='format:%h (\"%s\")'
>
> $ git one 247f2f6f3c706b40b5f3886646f3eb53671258bf
> 247f2f6f3c70 ("sched/core: Don't schedule threads on pre-empted vCPUs")
>
> which gives the normal commit quote style.
>

Thanks! updated :)

Regards,
Rohit