linux-kernel - Re: [PATCH v2] ipc: Adding new return type vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqt6zai16qZ--L9aAh0dtD9XTfu-vpUpO4CWgOHKavxH5AU1Q@mail.gmail.com>
Date:   Thu, 10 May 2018 19:34:16 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>, manfred@...orfullife.com,
        dave@...olabs.net, ebiederm@...ssion.com,
        linux@...inikbrodowski.net
Cc:     linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v2] ipc: Adding new return type vm_fault_t

On Wed, Apr 25, 2018 at 10:04 AM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> Reviewed-by: Matthew Wilcox <mawilcox@...rosoft.com>
> ---
> v2: Updated the change log
>
>  ipc/shm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ipc/shm.c b/ipc/shm.c
> index 4643865..2ba0cfc 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -378,7 +378,7 @@ void exit_shm(struct task_struct *task)
>         up_write(&shm_ids(ns).rwsem);
>  }
>
> -static int shm_fault(struct vm_fault *vmf)
> +static vm_fault_t shm_fault(struct vm_fault *vmf)
>  {
>         struct file *file = vmf->vma->vm_file;
>         struct shm_file_data *sfd = shm_file_data(file);
> --
> 1.9.1
>

Any comment for this patch ?