linux-kernel - [PATCH v2] ANDROID: binder: correct the cmd print for BINDER_WORK_RETURN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1525917903067.93656@xiaomi.com>
Date:   Thu, 10 May 2018 02:05:03 +0000
From:   宋金时 <songjinshi@...omi.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "maco@...roid.com" <maco@...roid.com>,
        "tkjos@...gle.com" <tkjos@...gle.com>,
        "arve@...roid.com" <arve@...roid.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH v2] ANDROID: binder: correct the cmd print for
 BINDER_WORK_RETURN_ERROR

When to execute binder_stat_br the e->cmd has been modifying as BR_OK 
instead of the original return error cmd, in fact we want to know the 
original return error, such as BR_DEAD_REPLY or BR_FAILED_REPLY, etc. 
instead of always BR_OK, in order to avoid the value of the e->cmd is 
always BR_OK, so we need assign the value of the e->cmd to cmd before 
e->cmd = BR_OK.

Signed-off-by: songjinshi <songjinshi@...omi.com>
---
 drivers/android/binder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 764b63a..a85d260 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3917,10 +3917,11 @@ static int binder_thread_read(struct binder_proc *proc,
 			binder_inner_proc_unlock(proc);
 			if (put_user(e->cmd, (uint32_t __user *)ptr))
 				return -EFAULT;
+			cmd = e->cmd;
 			e->cmd = BR_OK;
 			ptr += sizeof(uint32_t);
 
-			binder_stat_br(proc, thread, e->cmd);
+			binder_stat_br(proc, thread, cmd);
 		} break;
 		case BINDER_WORK_TRANSACTION_COMPLETE: {
 			binder_inner_proc_unlock(proc);
-- 
1.9.1