linux-kernel - Re: [PATCH v2] perf buildid-cache: Warn --purge-all failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 May 2018 00:37:52 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Cc:     acme@...nel.org, jolsa@...hat.com, namhyung@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perf buildid-cache: Warn --purge-all failures

On Thu, 10 May 2018 10:06:51 +0530
Ravi Bangoria <ravi.bangoria@...ux.ibm.com> wrote:

> Warn perf buildid-cache --purge-all failures in non verbose mode.
> Ex,
> 
>   $ sudo chown root:root /home/ravi/.debug -R
>   $ sudo chmod 700 /home/ravi/.debug/ -R
>   $ ./perf buildid-cache -P
>     Couldn't remove some caches. Error: Permission denied.
> 
> Suggested-by: Masami Hiramatsu <mhiramat@...nel.org>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>

This looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks!

> ---
>  tools/perf/builtin-buildid-cache.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
> index 7a7403913b57..ef6b3cc8d57d 100644
> --- a/tools/perf/builtin-buildid-cache.c
> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -488,8 +488,12 @@ int cmd_buildid_cache(int argc, const char **argv)
>  		}
>  	}
>  
> -	if (purge_all)
> -		ret = build_id_cache__purge_all();
> +	if (purge_all) {
> +		if (build_id_cache__purge_all()) {
> +			pr_warning("Couldn't remove some caches. Error: %s.\n",
> +				str_error_r(errno, sbuf, sizeof(sbuf)));
> +		}
> +	}
>  
>  	if (missing_filename)
>  		ret = build_id_cache__fprintf_missing(session, stdout);
> -- 
> 2.14.3
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>