linux-kernel - Re: [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180510183922.GA12846@amd>
Date:   Thu, 10 May 2018 20:39:22 +0200
From:   Pavel Machek <pavel@....cz>
To:     "Andrew F. Davis" <afd@...com>
Cc:     Dan Murphy <dmurphy@...com>, robh+dt@...nel.org,
        mark.rutland@....com, jacek.anaszewski@...il.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver

Hi!

> >> Plus, removing the driver is not a command to disable the LED anyway.
> > 
> > True but you don't want to leave any LEDs in the on state without a driver to support it.
> > This could burn out the LED or the board if left on on max brightness
> 
> I disagree, we should not try to decide what the user wants here. We
> should only do what we are instructed to do, which for remove() is to
> cleanup what probe has done so the driver can be removed w/o leaking
> memory or device state.

We normally powerdown on rmmod. We should do that here, too.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)