linux-kernel - Re: [PATCH] staging: lustre: o2iblnd: Fix crash in kiblnd_handle_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201805110304.MOAwHAIT%fengguang.wu@intel.com>
Date:   Fri, 11 May 2018 03:15:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Doug Oucharek <dougso@...com>
Cc:     kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH] staging: lustre: o2iblnd: Fix crash in
 kiblnd_handle_early_rxs()

Hi Doug,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.17-rc4 next-20180510]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Doug-Oucharek/staging-lustre-o2iblnd-Fix-crash-in-kiblnd_handle_early_rxs/20180511-004953
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function 'kiblnd_handle_early_rxs':
   drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:161: error: 'kib_rx_t' undeclared (first use in this function); did you mean 'kib_rx'?
      rx = list_entry(conn->ibc_early_rxs.next,
                                                                                                                                                                    ^       
                                                                                                                                                                    kib_rx
   drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:161: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:171: error: expected expression before ')' token
      rx = list_entry(conn->ibc_early_rxs.next,
                                                                                                                                                                              ^
   drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:468: error: expected expression before ')' token
      rx = list_entry(conn->ibc_early_rxs.next,
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       ^

vim +1974 drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c

  1962	
  1963	static void
  1964	kiblnd_handle_early_rxs(struct kib_conn *conn)
  1965	{
  1966		unsigned long flags;
  1967		struct kib_rx *rx;
  1968	
  1969		LASSERT(!in_interrupt());
  1970		LASSERT(conn->ibc_state >= IBLND_CONN_ESTABLISHED);
  1971	
  1972		write_lock_irqsave(&kiblnd_data.kib_global_lock, flags);
  1973		while (!list_empty(&conn->ibc_early_rxs)) {
> 1974			rx = list_entry(conn->ibc_early_rxs.next,
  1975					kib_rx_t, rx_list);
  1976			list_del(&rx->rx_list);
  1977			write_unlock_irqrestore(&kiblnd_data.kib_global_lock, flags);
  1978	
  1979			kiblnd_handle_rx(rx);
  1980	
  1981			write_lock_irqsave(&kiblnd_data.kib_global_lock, flags);
  1982		}
  1983		write_unlock_irqrestore(&kiblnd_data.kib_global_lock, flags);
  1984	}
  1985	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (62264 bytes)