linux-kernel - Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180510.153730.348233195080672901.davem@davemloft.net>
Date:   Thu, 10 May 2018 15:37:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mgamal@...hat.com
Cc:     netdev@...r.kernel.org, sthemmin@...rosoft.com, kys@...rosoft.com,
        haiyangz@...rosoft.com, devel@...uxdriverproject.org,
        vkuznets@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows
 hosts

From: Mohammed Gamal <mgamal@...hat.com>
Date: Wed,  9 May 2018 10:17:34 +0200

> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change, channel change) to fail after the device
> is detached once, returning -ENODEV.
> 
> Instead of returning the device instabce, we take the exit path where
> we call netif_device_attach()
> 
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> 
> Signed-off-by: Mohammed Gamal <mgamal@...hat.com>

Applied.