linux-kernel - Re: [PATCH v2 2/2] soc: mediatek: reuse regmap_read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68d230e8-2f9f-ae84-95d0-d8bf22f8f43b@gmail.com>
Date:   Fri, 11 May 2018 13:25:02 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     sean.wang@...iatek.com, rjw@...ysocki.net, khilman@...libre.com
Cc:     ulf.hansson@...aro.org, linux-mediatek@...ts.infradead.org,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Weiyi Lu <weiyi.lu@...iatek.com>
Subject: Re: [PATCH v2 2/2] soc: mediatek: reuse regmap_read_poll_timeout
 helpers

Hi Sean,

On 04/23/2018 08:42 AM, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> Reuse the common helpers regmap_read_poll_timeout provided by Linux core
> instead of an open-coded handling.
> 
> v1 -> v2:
>  - use macro definitions MTK_POLL_DELAY_US and MTK_POLL_TIMEOUT for
>    arguments sleep_us and timeout_us passing in regmap_read_poll_timeout.
>  - remove unnecessary linux/iopoll.h being included in.
> 

I just realized that you wrote the changelog here, which will make it show up in
the commit log. Thant's not what we want... (see below)

> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Weiyi Lu <weiyi.lu@...iatek.com>
> ---
>  drivers/soc/mediatek/mtk-infracfg.c | 46 ++++++++++---------------------------
>  1 file changed, 12 insertions(+), 34 deletions(-)
> 

Please write your changelog here in the future.
I'll fix that up in my tree now, but please remember the next time :)
Thanks
Matthias