linux-kernel - Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1526052671.26291.58.camel@linux.intel.com>
Date:   Fri, 11 May 2018 16:31:11 +0100
From:   Alan Cox <alan@...ux.intel.com>
To:     Julia Lawall <julia.lawall@...6.fr>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     sakari.ailus@...ux.intel.com, mchehab@...nel.org,
        gregkh@...uxfoundation.org, andriy.shevchenko@...ux.intel.com,
        chen.chenchacha@...mail.com, keescook@...omium.org,
        arvind.yadav.cs@...il.com, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path
 in 'lm3554_probe()'

On Fri, 2018-05-11 at 17:09 +0200, Julia Lawall wrote:
> 
> On Fri, 11 May 2018, Christophe JAILLET wrote:
> 
> > The use of 'fail1' and 'fail2' is not correct. Reorder these calls
> > to
> > branch at the right place of the error handling path.
> 
> Maybe it would be good to improve the names at the same time?

Its scheduled for deletion - please don't bother.

Alan