linux-kernel - Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 May 2018 23:50:05 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Thierry Reding <thierry.reding@...il.com>, airlied@...ux.ie,
        jonathanh@...dia.com, dri-devel@...ts.freedesktop.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

On Mon, Apr 23, 2018 at 4:24 PM, Matthew Wilcox <willy@...radead.org> wrote:
> On Wed, Apr 18, 2018 at 10:24:39AM +0200, Thierry Reding wrote:
>> > @@ -437,20 +436,7 @@ static int tegra_bo_fault(struct vm_fault *vmf)
>> >     offset = (vmf->address - vma->vm_start) >> PAGE_SHIFT;
>> >     page = bo->pages[offset];
>> >
>> > -   err = vm_insert_page(vma, vmf->address, page);
>> > -   switch (err) {
>> > -   case -EAGAIN:
>> > -   case 0:
>> > -   case -ERESTARTSYS:
>> > -   case -EINTR:
>> > -   case -EBUSY:
>> > -           return VM_FAULT_NOPAGE;
>> > -
>> > -   case -ENOMEM:
>> > -           return VM_FAULT_OOM;
>> > -   }
>> > -
>> > -   return VM_FAULT_SIGBUS;
>> > +   return vmf_insert_page(vma, vmf->address, page);
>> >  }
>>
>> This new function returns VM_FAULT_NOPAGE only for 0 and -EBUSY, whereas
>> we used to return VM_FAULT_NOPAGE for -EAGAIN, -ERESTARTSYS and -EINTR
>> as well. Was this previously wrong?
>
> Not so much wrong as unnecessary.  vm_insert_page() can't return -EAGAIN,
> -ERESTARTSYS or -EINTR.

If no further comment on this patch, We would like to get this patch
queued for 4.18.