linux-kernel - Re: [PATCH v3 1/3] big key: get rid of stack array allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.1805120609250.6601@namei.org>
Date:   Sat, 12 May 2018 06:09:49 +1000 (AEST)
From:   James Morris <jmorris@...ei.org>
To:     Tycho Andersen <tycho@...ho.ws>
cc:     David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
        "Serge E. Hallyn" <serge@...lyn.com>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Eric Biggers <ebiggers3@...il.com>
Subject: Re: [PATCH v3 1/3] big key: get rid of stack array allocation

On Tue, 24 Apr 2018, Tycho Andersen wrote:

> We're interested in getting rid of all of the stack allocated arrays in the
> kernel [1]. This patch simply hardcodes the iv length to match that of the
> hardcoded cipher.
> 
> [1]: https://lkml.org/lkml/2018/3/7/621
> 
> v2: hardcode the length of the nonce to be the GCM AES IV length, and do a
>     sanity check in init(), Eric Biggers
> v3: * remember to free big_key_aead when sanity check fails
>     * define a constant for big key IV size so it can be changed along side
>       the algorithm in the code

All applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
and next-testing


Thanks!


-- 
James Morris
<jmorris@...ei.org>