linux-kernel - Re: [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfLuiyLC-C=0HKAeWH3-Qd_fJ6WCOTN7s4VAwLkRzakdw@mail.gmail.com>
Date:   Mon, 14 May 2018 01:49:54 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Vaibhav Murkute <vaibhavmurkute88@...il.com>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces

On Sat, May 12, 2018 at 1:12 AM, Vaibhav Murkute
<vaibhavmurkute88@...il.com> wrote:
> checkpatch.pl shows a warning for these unnecessary curly braces.
> so just removed those curly braces.
>
> Signed-off-by: Vaibhav Murkute <vaibhavmurkute88@...il.com>
> ---
>  drivers/bluetooth/hci_serdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
> index e0e6461..137c314 100644
> --- a/drivers/bluetooth/hci_serdev.c
> +++ b/drivers/bluetooth/hci_serdev.c
> @@ -204,9 +204,9 @@ static int hci_uart_setup(struct hci_dev *hdev)
>                 return 0;
>         }
>
> -       if (skb->len != sizeof(*ver)) {
> +       if (skb->len != sizeof(*ver))
>                 bt_dev_err(hdev, "Event length mismatch for version info");
> -       }
> +
>
>         kfree_skb(skb);
>         return 0;

Why did you add redundant empty line(s) instead?


-- 
With Best Regards,
Andy Shevchenko