linux-kernel - Re: [PATCH v5 03/13] ALSA: hda/ca0132: Add PCI region2 iomap for SBZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hpo2081lq.wl-tiwai@suse.de>
Date:   Sun, 13 May 2018 09:18:57 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Connor McAdams" <conmanx360@...il.com>
Cc:     <alsa-devel@...a-project.org>,
        "Jérémy Lefaure" <jeremy.lefaure@....epita.fr>,
        "Jaroslav Kysela" <perex@...ex.cz>, <o-takashi@...amocchi.jp>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 03/13] ALSA: hda/ca0132: Add PCI region2 iomap for SBZ

On Tue, 08 May 2018 19:20:03 +0200,
Connor McAdams wrote:
> 
> This patch adds iomapping for the region2 section of memory on the SBZ.
> This memory region is used in later patches for setting inputs and
> outputs. If the mapping fails, the quirk is changed back to QUIRK_NONE
> to avoid attempts to write to uninitialized memory.
> 
> It also adds a new exit sequence to unmap the iomem for the SBZ.
> 
> Signed-off-by: Connor McAdams <conmanx360@...il.com>
> ---
>  sound/pci/hda/patch_ca0132.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index 02238fe..78d2c26 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -29,6 +29,9 @@
>  #include <linux/firmware.h>
>  #include <linux/kernel.h>
>  #include <sound/core.h>
> +#include <linux/types.h>
> +#include <linux/io.h>
> +#include <linux/pci.h>
>  #include "hda_codec.h"
>  #include "hda_local.h"
>  #include "hda_auto_parser.h"

The linux/*.h inclusion should be before sound/*.h.
But never mind, I fixed it locally, so no need for resubmission.


thanks,

Takashi