linux-kernel - Re: [PATCH 01/13] Coding style changes to block comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180514155858.GA30973@kroah.com>
Date:   Mon, 14 May 2018 17:58:58 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     John Whitmore <johnfwhitmore@...il.com>
Cc:     kstewart@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, colin.king@...onical.com,
        tglx@...utronix.de
Subject: Re: [PATCH 01/13] Coding style changes to block comments

On Mon, May 14, 2018 at 04:53:06PM +0100, John Whitmore wrote:
> The file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c has a lot of
> coding style issues, this will be the first of many small patches which clear
> up some, if not all, of the problems with the file.

This isn't a good changelog comment.  It should explain why you are
doing what you are doing, and maybe what, at the very least.  Saying
something will happen in the future isn't good.

Also your subject line should have the subsystem/driver in it, to make
it more obvious.  Something like:
	Subject: staging: rtl8192u: fix block comments in rtl819x_HTProc.c

There are thousands of good examples of good changelog comments and
subject lines in the email archives, and in the kernel log itself :)

Please fix this up and redo the whole series and resend.

thanks,

greg k-h