linux-kernel - Re: [PATCH 01/18] kernel: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhRS1ww3Hv44p3W3C7WBoefrU2shQM4UHL8b6MK1kHso3g@mail.gmail.com>
Date:   Mon, 14 May 2018 14:59:46 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Eric Paris <eparis@...hat.com>,
        Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jessica Yu <jeyu@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        Balbir Singh <bsingharora@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Josh Triplett <josh@...htriplett.org>,
        Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org, linux-audit@...hat.com
Subject: Re: [PATCH 01/18] kernel: Use pr_fmt

On Thu, May 10, 2018 at 11:45 AM, Joe Perches <joe@...ches.com> wrote:
> Sometime in the future, it would be useful to convert pr_fmt from a
> default simple define to use a default prefix with KBUILD_MODNAME.
>
> There are files in kernel/ that use pr_<level>, some with an embedded
> prefix, that also do not have a specific pr_fmt define.
>
> Add pr_fmt for those files.
>
> There are some differences in output as some messages are now prefixed
> with their KBUILD_MODNAME.
>
> Miscellanea:
>
> o Align multiline statements to open parenthesis
> o Wrap and realign arguments to 80 columns where sensible
> o Coalesce formats
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  kernel/acct.c          |  2 ++
>  kernel/async.c         | 14 ++++++------
>  kernel/audit_tree.c    |  2 +-
>  kernel/backtracetest.c |  8 +++----
>  kernel/crash_core.c    | 29 ++++++++++++++-----------
>  kernel/exit.c          |  2 ++
>  kernel/hung_task.c     | 13 +++++------
>  kernel/kprobes.c       | 20 ++++++++++-------
>  kernel/module.c        | 59 +++++++++++++++++++++++---------------------------
>  kernel/panic.c         |  3 +++
>  kernel/params.c        | 13 ++++++-----
>  kernel/pid.c           |  2 ++
>  kernel/profile.c       |  2 ++
>  kernel/range.c         |  2 +-
>  kernel/relay.c         |  5 ++++-
>  kernel/seccomp.c       |  4 +++-
>  kernel/signal.c        | 10 +++++----
>  kernel/smpboot.c       |  5 ++++-
>  kernel/taskstats.c     |  4 +++-
>  kernel/torture.c       |  6 +++--
>  kernel/tracepoint.c    |  3 +++
>  kernel/workqueue.c     |  2 ++
>  22 files changed, 122 insertions(+), 88 deletions(-)

The audit change looks fine to me, thanks Joe.

Acked-by: Paul Moore <paul@...l-moore.com>

> diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
> index 67e6956c0b61..f34f90b4a346 100644
> --- a/kernel/audit_tree.c
> +++ b/kernel/audit_tree.c
> @@ -739,7 +739,7 @@ static int audit_launch_prune(void)
>         prune_thread = kthread_run(prune_tree_thread, NULL,
>                                 "audit_prune_tree");
>         if (IS_ERR(prune_thread)) {
> -               pr_err("cannot start thread audit_prune_tree");
> +               pr_err("cannot start thread audit_prune_tree\n");
>                 prune_thread = NULL;
>                 return -ENOMEM;
>         }

-- 
paul moore
www.paul-moore.com