linux-kernel - Re: [PATCH 15/17] efi/x86: Ignore unrealistically large option roms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180514064051.GA16596@gmail.com>
Date:   Mon, 14 May 2018 08:40:51 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     linux-efi@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/17] efi/x86: Ignore unrealistically large option roms


* Ard Biesheuvel <ard.biesheuvel@...aro.org> wrote:

> +	/*
> +	 * Some firmwares contain EFI function pointers at the place where the
> +	 * romimage and romsize fields are supposed to be. Typically the EFI
> +	 * code is mapped at high addresses, translating to an unrealistically
> +	 * large romsize. The UEFI spec limits the size of option ROMs to 16
> +	 * MiB so we reject any roms over 16 MiB in size to catch this.
> +	 */

JFYI, I fixed this:

 s/Some firmwares contain
  /Some firmware images contain

and:

 s/roms
  /ROMs

(Looks good otherwise, no need to resend.)

Thanks,

	Ingo