linux-kernel - Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180514210550.GM26088@linux.vnet.ibm.com>
Date:   Mon, 14 May 2018 14:05:50 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Joe Perches <joe@...ches.com>,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 01:52:48PM -0700, Randy Dunlap wrote:
> On 05/14/2018 01:29 PM, Paul E. McKenney wrote:
> > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote:
> >> Use a consistent logging prefix for all rcu related output.
> >>
> >> Signed-off-by: Joe Perches <joe@...ches.com>
> > 
> > I took parts of this (thank you!) but have concerns about other parts.
> > 
> >> ---
> >>  kernel/rcu/rcu_segcblist.c |  2 ++
> >>  kernel/rcu/rcuperf.c       | 10 ++++---
> >>  kernel/rcu/rcutorture.c    | 46 +++++++++++++++----------------
> >>  kernel/rcu/srcutiny.c      |  2 ++
> >>  kernel/rcu/srcutree.c      |  5 +++-
> >>  kernel/rcu/tiny.c          |  3 +++
> >>  kernel/rcu/tree.c          |  8 +++---
> >>  kernel/rcu/tree_plugin.h   | 67 +++++++++++++++++++++++++++-------------------
> >>  kernel/rcu/update.c        | 19 ++++++++-----
> >>  9 files changed, 96 insertions(+), 66 deletions(-)
> >>
> 
> >> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> >> index 648e1c25707d..45d98ff0d5b8 100644
> >> --- a/kernel/rcu/rcutorture.c
> >> +++ b/kernel/rcu/rcutorture.c
> >> @@ -22,6 +22,7 @@
> >>   *
> >>   * See also:  Documentation/RCU/torture.txt
> >>   */
> >> +
> >>  #include <linux/types.h>
> >>  #include <linux/kernel.h>
> >>  #include <linux/init.h>
> >> @@ -908,7 +909,7 @@ rcu_torture_writer(void *arg)
> >>  	VERBOSE_TOROUT_STRING("rcu_torture_writer task started");
> >>  	if (!can_expedite)
> >>  		pr_alert("%s" TORTURE_FLAG
> >> -			 " GP expediting controlled from boot/sysfs for %s.\n",
> >> +			 " GP expediting controlled from boot/sysfs for %s\n",
> >>  			 torture_type, cur_ops->name);
> >>
> >>  	/* Initialize synctype[] array.  If none set, take default. */
> >> @@ -916,27 +917,27 @@ rcu_torture_writer(void *arg)
> >>  		gp_cond1 = gp_exp1 = gp_normal1 = gp_sync1 = true;
> >>  	if (gp_cond1 && cur_ops->get_state && cur_ops->cond_sync) {
> >>  		synctype[nsynctypes++] = RTWS_COND_GET;
> >> -		pr_info("%s: Testing conditional GPs.\n", __func__);
> >> +		pr_info("%s: Testing conditional GPs\n", __func__);
> >>  	} else if (gp_cond && (!cur_ops->get_state || !cur_ops->cond_sync)) {
> >> -		pr_alert("%s: gp_cond without primitives.\n", __func__);
> >> +		pr_alert("%s: gp_cond without primitives\n", __func__);
> >>  	}
> >>  	if (gp_exp1 && cur_ops->exp_sync) {
> >>  		synctype[nsynctypes++] = RTWS_EXP_SYNC;
> >> -		pr_info("%s: Testing expedited GPs.\n", __func__);
> >> +		pr_info("%s: Testing expedited GPs\n", __func__);
> >>  	} else if (gp_exp && !cur_ops->exp_sync) {
> >> -		pr_alert("%s: gp_exp without primitives.\n", __func__);
> >> +		pr_alert("%s: gp_exp without primitives\n", __func__);
> 
> Unlike some of the others, the one above is not a sentence, so it doesn't
> _need_ a period ... except for consistency.
> 
> But I don't care either way. :)

;-) ;-) ;-)

							Thanx, Paul

> >>  	}
> >>  	if (gp_normal1 && cur_ops->deferred_free) {
> >>  		synctype[nsynctypes++] = RTWS_DEF_FREE;
> >> -		pr_info("%s: Testing asynchronous GPs.\n", __func__);
> >> +		pr_info("%s: Testing asynchronous GPs\n", __func__);
> >>  	} else if (gp_normal && !cur_ops->deferred_free) {
> >> -		pr_alert("%s: gp_normal without primitives.\n", __func__);
> >> +		pr_alert("%s: gp_normal without primitives\n", __func__);
> >>  	}
> >>  	if (gp_sync1 && cur_ops->sync) {
> >>  		synctype[nsynctypes++] = RTWS_SYNC;
> >> -		pr_info("%s: Testing normal GPs.\n", __func__);
> >> +		pr_info("%s: Testing normal GPs\n", __func__);
> >>  	} else if (gp_sync && !cur_ops->sync) {
> >> -		pr_alert("%s: gp_sync without primitives.\n", __func__);
> >> +		pr_alert("%s: gp_sync without primitives\n", __func__);
> 
> 
> 
> 
> 
> 
> 
> 
> -- 
> ~Randy
>