linux-kernel - Re: [PATCH] efi/x86: Clean up the eboot code a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu9gzHXNfHwZAoXfOX4F-UbsGjbjZce-iD00E-uqRrC88Q@mail.gmail.com>
Date:   Mon, 14 May 2018 08:59:33 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     linux-efi@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Hans de Goede <hdegoede@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] efi/x86: Clean up the eboot code a bit

On 14 May 2018 at 08:58, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Ard Biesheuvel <ard.biesheuvel@...aro.org> wrote:
>
>> On 14 May 2018 at 08:43, Ingo Molnar <mingo@...nel.org> wrote:
>> >
>> > So I looked at arch/x86/boot/compressed/eboot.c to improve a printk message and
>> > ended up with the cleanups below.
>> >
>> > Only build tested.
>> >
>> > Thanks,
>> >
>> >         Ingo
>> >
>> > =================>
>> > Subject: efi/x86: Clean up the eboot code
>> > From: Ingo Molnar <mingo@...nel.org>
>> > Date: Mon May 14 08:33:40 CEST 2018
>> >
>> > Various small cleanups:
>> >
>> >  - Standardize printk messages:
>> >
>> >      'alloc' => 'allocate'
>> >      'mem'   => 'memory'
>> >
>> >    also put variable names in printk messages between quotes.
>> >
>> >  - Align mass-assignments vertically for better readability
>> >
>> >  - Break multi-line function prototypes at the name where possible,
>> >    not in the middle of the parameter list
>> >
>> >  - Use a newline before return statements consistently.
>> >
>> >  - Use curly braces in a balanced fashion.
>> >
>> >  - Remove stray newlines.
>> >
>> > No change in functionality.
>> >
>> > Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
>> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>> > Cc: Matt Fleming <matt@...eblueprint.co.uk>
>> > Cc: Peter Zijlstra <peterz@...radead.org>
>> > Cc: Thomas Gleixner <tglx@...utronix.de>
>> > Cc: linux-efi@...r.kernel.org
>> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
>>
>> Thanks Ingo
>>
>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
>
> Thanks - mind picking it up into your tree? I only did minimal testing and don't
> want to interfere with your patch flow either.
>

Will do, thanks.