linux-kernel - 答复: reply: [PATCH v3 1/2] PCI: kirin: Add MSI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 May 2018 07:40:17 +0000
From:   songxiaowei <songxiaowei@...ilicon.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "chenyao (F)" <chenyao11@...wei.com>,
        Wangbinghui <wangbinghui@...ilicon.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "xuwei (O)" <xuwei5@...wei.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "Catalin Marinas" <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        "dimitrysh@...gle.com" <dimitrysh@...gle.com>,
        "guodong.xu@...aro.org" <guodong.xu@...aro.org>,
        Suzhuangluan <suzhuangluan@...ilicon.com>,
        Kongfei <kongfei@...ilicon.com>
Subject: 答复: reply: [PATCH v3 1/2] PCI: kirin: Add MSI support

Hi Andy Shevchenko

> -----邮件原件-----
> 发件人: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> 发送时间: 2018年5月14日 15:17
> 收件人: songxiaowei <songxiaowei@...ilicon.com>
> 抄送: chenyao (F) <chenyao11@...wei.com>; Wangbinghui
> <wangbinghui@...ilicon.com>; Lorenzo Pieralisi <lorenzo.pieralisi@....com>;
> Bjorn Helgaas <bhelgaas@...gle.com>; xuwei (O) <xuwei5@...wei.com>;
> Rob Herring <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>;
> Catalin Marinas <catalin.marinas@....com>; Will Deacon
> <will.deacon@....com>; linux-pci@...r.kernel.org; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; linux-arm Mailing List
> <linux-arm-kernel@...ts.infradead.org>; devicetree
> <devicetree@...r.kernel.org>; dimitrysh@...gle.com;
> guodong.xu@...aro.org; Suzhuangluan <suzhuangluan@...ilicon.com>; Kongfei
> <kongfei@...ilicon.com>
> 主题: Re: reply: [PATCH v3 1/2] PCI: kirin: Add MSI support
> 
> On Mon, May 14, 2018 at 4:11 AM, songxiaowei <songxiaowei@...ilicon.com>
> wrote:
> 
> >> > +       int ret;
> >> > +
> >> > +       if (IS_ENABLED(CONFIG_PCI_MSI)) {
> >>
> >> > +               pci->pp.msi_irq = platform_get_irq(pdev, 0);
> >> > +               if (pci->pp.msi_irq < 0) {
> >> > +                       dev_err(&pdev->dev, "failed to get MSI IRQ
> >> (%d)\n",
> >> > +                               pci->pp.msi_irq);
> >>
> >> > +                       return -ENODEV;
> >>
> >> Why shadowing actual error code?
> > [songxiaowei]  Sorry, I can't get your point about this, would you explain it
> for me.
> 
> platform_get_irq() returns either correct IRQ number or negative error code.
> In the code above you shadow the actual error (as returned by that
> call) by -ENODEV. Any reason why?
> 
[songxiaowei] I guess the reason is that she wanted to keep the same with other hosts,
           So, you'd like to use "return pci->pp.msi_irq " instead of " return -ENODEV ".
> --
> With Best Regards,
> Andy Shevchenko

Thanks a lot,
Xiaowei.