linux-kernel - Re: [PATCH 3/4] drm/panel: otm8009a: no message if probe success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 May 2018 08:38:35 +0000
From:   Vincent ABRIOU <vincent.abriou@...com>
To:     Philippe CORNU <philippe.cornu@...com>,
        Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Andrzej Hajda <a.hajda@...sung.com>,
        Yannick FERTRE <yannick.fertre@...com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Alexandre TORGUE <alexandre.torgue@...com>
Subject: Re: [PATCH 3/4] drm/panel: otm8009a: no message if probe success

Hi Philippe,

Reviewed-by: Vincent Abriou <vincent.abriou@...com>

BR
Vincent

On 04/23/2018 04:10 PM, Philippe Cornu wrote:
> Remove the message in case of probe success. This comes from
> a suggestion followed in the recent integration of the
> raydium rm68200 panel.
> 
> Signed-off-by: Philippe Cornu <philippe.cornu@...com>
> ---
>   drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index de4a16d5275c..4c638b7b9943 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -14,8 +14,6 @@
>   #include <linux/regulator/consumer.h>
>   #include <video/mipi_display.h>
>   
> -#define DRV_NAME "orisetech_otm8009a"
> -
>   #define OTM8009A_BACKLIGHT_DEFAULT	240
>   #define OTM8009A_BACKLIGHT_MAX		255
>   
> @@ -461,7 +459,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
>   	ctx->panel.dev = dev;
>   	ctx->panel.funcs = &otm8009a_drm_funcs;
>   
> -	ctx->bl_dev = backlight_device_register(DRV_NAME "_backlight", dev, ctx,
> +	ctx->bl_dev = backlight_device_register(dev_name(dev), dev, ctx,
>   						&otm8009a_backlight_ops, NULL);
>   	if (IS_ERR(ctx->bl_dev)) {
>   		dev_err(dev, "failed to register backlight device\n");
> @@ -483,11 +481,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
>   		return ret;
>   	}
>   
> -	DRM_INFO(DRV_NAME "_panel %ux%u@%u %ubpp dsi %udl - ready\n",
> -		 default_mode.hdisplay, default_mode.vdisplay,
> -		 default_mode.vrefresh,
> -		 mipi_dsi_pixel_format_to_bpp(dsi->format), dsi->lanes);
> -
>   	return 0;
>   }
>   
> @@ -513,7 +506,7 @@ static struct mipi_dsi_driver orisetech_otm8009a_driver = {
>   	.probe  = otm8009a_probe,
>   	.remove = otm8009a_remove,
>   	.driver = {
> -		.name = DRV_NAME "_panel",
> +		.name = "panel-orisetech-otm8009a",
>   		.of_match_table = orisetech_otm8009a_of_match,
>   	},
>   };
>