linux-kernel - Re: [RFC PATCH v3 5/5] usb: typec: tcpm: Support for Alternate Modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180514104014.GB21435@kuha.fi.intel.com>
Date:   Mon, 14 May 2018 13:40:14 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Hans de Goede <hdegoede@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jun Li <jun.li@....com>,
        Mats Karrman <mats.dev.list@...il.com>,
        USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v3 5/5] usb: typec: tcpm: Support for Alternate Modes

On Sun, May 13, 2018 at 12:30:51AM +0300, Andy Shevchenko wrote:
> On Fri, May 11, 2018 at 4:18 PM, Heikki Krogerus
> <heikki.krogerus@...ux.intel.com> wrote:
> > This adds more complete handling of VDMs and registration of
> > partner alternate modes, and introduces callbacks for
> > alternate mode operations.
> >
> > Only DFP role is supported for now.
> 
> > +       for (i = 0; i < cnt; i++)
> > +               p[i] = le32_to_cpu(payload[i]);
> 
> I would recommend to consider to use le32_to_cpu_array().
> 
> Though, actually we have slightly different API for BE and LE cases.
> For LE existing would be renamed to rather le32_to_cpus_array() and
> establishing the former one in the similar way how be32_to_cpu_array()
> is implemented.

OK. I'll check it.


Thanks Andy,

-- 
heikki