linux-kernel - Re: [PATCH net V2] tun: fix use after free for ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180513.201851.1296027654181841669.davem@davemloft.net>
Date:   Sun, 13 May 2018 20:18:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jasowang@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        xiyou.wangcong@...il.com, eric.dumazet@...il.com, mst@...hat.com
Subject: Re: [PATCH net V2] tun: fix use after free for ptr_ring

From: Jason Wang <jasowang@...hat.com>
Date: Fri, 11 May 2018 10:49:25 +0800

> We used to initialize ptr_ring during TUNSETIFF, this is because its
> size depends on the tx_queue_len of netdevice. And we try to clean it
> up when socket were detached from netdevice. A race were spotted when
> trying to do uninit during a read which will lead a use after free for
> pointer ring. Solving this by always initialize a zero size ptr_ring
> in open() and do resizing during TUNSETIFF, and then we can safely do
> cleanup during close(). With this, there's no need for the workaround
> that was introduced by commit 4df0bfc79904 ("tun: fix a memory leak
> for tfile->tx_array").
> 
> Reported-by: syzbot+e8b902c3c3fadf0a9dba@...kaller.appspotmail.com
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Fixes: 1576d9860599 ("tun: switch to use skb array for tx")
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Jason, please address Cong Wang's concerns.

Thank you.