linux-kernel - Re: [PATCH v2] Revert "alx: remove WoL support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180514.093504.1396660355199793729.davem@davemloft.net>
Date:   Mon, 14 May 2018 09:35:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     acelan.kao@...onical.com
Cc:     jcliburn@...il.com, chris.snook@...il.com, rakesh@...era.com,
        netdev@...r.kernel.org, emily.chien@...onical.com, andrew@...n.ch,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Revert "alx: remove WoL support"

From: AceLan Kao <acelan.kao@...onical.com>
Date: Mon, 14 May 2018 11:28:39 +0800

> This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2.
> 
> The WoL feature is a must to pass Energy Star 6.1 and above,
> the power consumption will be measured during S3 with WoL is enabled.
> 
> Reverting "alx: remove WoL support", and will try to fix the unintentional
> wake up issue when WoL is enabled.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651
> 
> Signed-off-by: AceLan Kao <acelan.kao@...onical.com>

First, we must fix the problem that caused WoL to be disabled.

Then, and only then, can you re-enable it.

Thank you.