linux-kernel - Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABeXuvpi_dm6TE3pH_KGehgNwW177hJFBmR8u29w6KJH1aA1Kg@mail.gmail.com>
Date:   Sun, 13 May 2018 21:05:58 -0700
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        anton@...era.com, Felipe Balbi <balbi@...nel.org>,
        "J. Bruce Fields" <bfields@...ldses.org>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        David Howells <dhowells@...hat.com>,
        David Sterba <dsterba@...e.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Christoph Hellwig <hch@....de>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Mike Marshall <hubcap@...ibond.com>, Jan Kara <jack@...e.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Jan Harkes <jaharkes@...cmu.edu>, Jiri Slaby <jslaby@...e.com>,
        Mark Fasheh <mark@...heh.com>,
        Miklos Szeredi <miklos@...redi.hu>,
        Nicolas Pitre <nico@...aro.org>,
        reiserfs-devel@...r.kernel.org,
        Richard Weinberger <richard@....at>,
        Sage Weil <sage@...hat.com>, Steve French <sfrench@...ba.org>,
        Steven Whitehouse <swhiteho@...hat.com>,
        Tejun Heo <tj@...nel.org>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        "Ted Ts'o" <tytso@....edu>
Subject: Re: [PATCH 6/6] vfs: change inode times to use struct timespec64

Al,

Are you ok with this approach to changing vfs timestamps?

Kees mentioned that he wants to merge a patch to pstore that changes
it to use timespec64 internally for 4.17:
https://lkml.org/lkml/2018/5/13/3

I'm not sure how we usually merge such flag day patches. Should this
be targeted for 4.17 or 4.18? The above might or might not be a
problem based on when this series is merged.

If you are ok with this approach, I could post a v2 with a couple of
requested fix-ups.

-Deepa

On Fri, May 11, 2018 at 11:44 PM, Kees Cook <keescook@...omium.org> wrote:
> On Fri, May 11, 2018 at 9:59 PM, Deepa Dinamani <deepa.kernel@...il.com> wrote:
>> diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
>> index 5fcb845b9fec..fb681d302bb3 100644
>> --- a/fs/pstore/inode.c
>> +++ b/fs/pstore/inode.c
>> @@ -392,7 +392,7 @@ int pstore_mkfile(struct dentry *root, struct pstore_record *record)
>>         inode->i_private = private;
>>
>>         if (record->time.tv_sec)
>> -               inode->i_mtime = inode->i_ctime = record->time;
>> +               inode->i_mtime = inode->i_ctime = timespec_to_timespec64(record->time);
>>
>>         d_add(dentry, inode);
>
> I'm fine to just convert pstore internally to timespec64 right now. Is
> it correct to say that I should use timespec64_to_timespec() here
> until this flag day patch? And I'd need to do this as well, yes?
>
> fs/pstore/platform.c:     record->time =
> ns_to_timespec64(ktime_get_real_fast_ns());
>
> Thanks!
>
> -Kees
>
> --
> Kees Cook
> Pixel Security