linux-kernel - Re: [PATCH 01/18] kernel: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180514223833.f3c2224e458e89949d3042d4@kernel.org>
Date:   Mon, 14 May 2018 22:38:33 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
        Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jessica Yu <jeyu@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        Balbir Singh <bsingharora@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Josh Triplett <josh@...htriplett.org>,
        Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org, linux-audit@...hat.com
Subject: Re: [PATCH 01/18] kernel: Use pr_fmt

On Thu, 10 May 2018 08:45:27 -0700
Joe Perches <joe@...ches.com> wrote:

> Sometime in the future, it would be useful to convert pr_fmt from a
> default simple define to use a default prefix with KBUILD_MODNAME.
> 
> There are files in kernel/ that use pr_<level>, some with an embedded
> prefix, that also do not have a specific pr_fmt define.
> 
> Add pr_fmt for those files.
> 
> There are some differences in output as some messages are now prefixed
> with their KBUILD_MODNAME.
> 
> Miscellanea:
> 
> o Align multiline statements to open parenthesis
> o Wrap and realign arguments to 80 columns where sensible
> o Coalesce formats
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Kprobes part looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks!

-- 
Masami Hiramatsu <mhiramat@...nel.org>