linux-kernel - Re: [PATCH 3/3] types: use fixed width types without double-underscore prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180515155925.9c16962e2b416e5f507c07b1@linux-foundation.org>
Date:   Tue, 15 May 2018 15:59:25 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Lihao Liang <lianglihao@...wei.com>,
        linux-kernel@...r.kernel.org,
        Philippe Ombredanne <pombredanne@...b.com>,
        Pekka Enberg <penberg@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3/3] types: use fixed width types without
 double-underscore prefix

On Tue, 15 May 2018 11:22:05 +0900 Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> This header file is not exported.  It is safe to reference types
> without double-underscore prefix.
> 

It may be safe to do this, but why is it desirable?

> index be15897..9834e90 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -10,14 +10,14 @@
>  #define DECLARE_BITMAP(name,bits) \
>  	unsigned long name[BITS_TO_LONGS(bits)]
>  
> -typedef __u32 __kernel_dev_t;
> +typedef u32 __kernel_dev_t;
>
> ...
>