linux-kernel - Re: [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 May 2018 08:01:13 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Oleksandr Andrushchenko <andr2000@...il.com>
Cc:     "Oleksandr_Andrushchenko@...m.com" <Oleksandr_Andrushchenko@...m.com>,
        alsa-devel@...a-project.org, xen-devel@...ts.xenproject.org,
        boris.ostrovsky@...cle.com, konrad.wilk@...cle.com, perex@...ex.cz,
        Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared buffers

On Tue, 15 May 2018 07:46:38 +0200,
Oleksandr Andrushchenko wrote:
> 
> On 05/14/2018 11:28 PM, Takashi Iwai wrote:
> > On Mon, 14 May 2018 08:27:40 +0200,
> > Oleksandr Andrushchenko wrote:
> >> --- /dev/null
> >> +++ b/sound/xen/xen_snd_front_shbuf.c
> >> @@ -0,0 +1,193 @@
> >> +// SPDX-License-Identifier: GPL-2.0 OR MIT
> >> +
> >> +/*
> >> + * Xen para-virtual sound device
> >> + *
> >> + * Copyright (C) 2016-2018 EPAM Systems Inc.
> >> + *
> >> + * Author: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
> >> + */
> >> +
> >> +#include <xen/xen.h>
> >> +#include <xen/xenbus.h>
> >> +
> >> +#include "xen_snd_front_shbuf.h"
> > Hm, with the local build test, I get the following error:
> >
> >    CC [M]  sound/xen/xen_snd_front_shbuf.o
> >    In file included from sound/xen/xen_snd_front_shbuf.c:11:0:
> >    ./include/xen/xen.h:18:8: error: unknown type name ‘bool’
> >     extern bool xen_pvh;
> >             ^~~~
> >     In file included from ./include/xen/interface/xen.h:30:0,
> >                      from ./include/xen/xen.h:29,
> >                      from sound/xen/xen_snd_front_shbuf.c:11:
> >    ./arch/x86/include/asm/xen/interface.h:92:21: error: unknown type name ‘uint64_t’
> >     DEFINE_GUEST_HANDLE(uint64_t);
> >                         ^
> > 			
> > Adding #include <linux/kernel.h> fixed the issue.
> >
> > Did you really test your patches with the latest Linus tree?
> My bad, it does build for ARM (which is my target), but also does
> need "#include <linux/kernel.h>" for x86 which I didn't build this time.
> Sorry about that.
> 
> Do you want me to resend this single patch or you can make the change
> while applying?

Yes, it's fine.


thanks,

Takashi