linux-kernel - Re: [PATCH 1/2] phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab9e5b1e-c765-c48c-4804-2657e7b8f4f1@codeaurora.org>
Date:   Tue, 15 May 2018 12:32:14 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Douglas Anderson <dianders@...omium.org>, kishon@...com
Cc:     linux-kernel@...r.kernel.org, Wei Yongjun <weiyongjun1@...wei.com>,
        Manu Gautam <mgautam@...eaurora.org>,
        Varadarajan Narayanan <varada@...eaurora.org>
Subject: Re: [PATCH 1/2] phy: qcom-qmp: Quiet -EPROBE_DEFER from
 qcom_qmp_phy_probe()

Hi Doug,


On 5/15/2018 4:12 AM, Douglas Anderson wrote:
> The -EPROBE_DEFER virus demands special case code to avoid printing
> error messages when the error is only -EPROBE_DEFER.  Spread the virus
> to a new host: qcom_qmp_phy_probe().  Specifically handle when our
> regulators might not be ready yet.
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
>
>   drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 6470c5d61d1c..a740daa58b31 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -1447,7 +1447,9 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>   
>   	ret = qcom_qmp_phy_vreg_init(dev);
>   	if (ret) {
> -		dev_err(dev, "failed to get regulator supplies\n");
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(dev, "failed to get regulator supplies: %d\n",
> +				ret);
>   		return ret;
>   	}
>   

Thanks for the patch. Looks good to me.
Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>

regards
Vivek