linux-kernel - Re: [PATCH 4.4 49/72] media: usbtv: prevent double free in error case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 May 2018 11:53:27 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Mauro Carvalho Chehab <mchehab@...pensource.com>
Cc:     Tuba Yavuz <tuba@....ufl.edu>,
        GregKroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org
Subject: Re: [PATCH 4.4 49/72] media: usbtv: prevent double free in error
 case

Am Montag, den 14.05.2018, 18:41 +0100 schrieb Ben Hutchings:
> 
> Shouldn't this bump the V4L2 device's reference count, i.e.:
> 
> 	v4l2_device_get(&usbtv->v4l2_dev);
> 

<censored>

You are right. Mixing refcounting sucks. I am preparing a patch.

	Regards
		Oliver