linux-kernel - Re: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180515181543.GW98604@atomide.com>
Date:   Tue, 15 May 2018 11:15:43 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Keerthy <j-keerthy@...com>
Cc:     Peter Ujfalusi <peter.ujfalusi@...com>, bcousson@...libre.com,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218
 irq type

* Keerthy <j-keerthy@...com> [180509 04:03]:
> 
> 
> On Tuesday 08 May 2018 07:46 PM, Tony Lindgren wrote:
> > * Peter Ujfalusi <peter.ujfalusi@...com> [180508 13:22]:
> >> Hi,
> >>
> >> While based on the datasheet of tps65218 the INT is low active, the GIC_SPI
> >> does not support anythin but IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING:
> >>
> >> [    2.761814] genirq: Setting trigger mode 8 for irq 102 failed (irq_chip_set_type_parent+0x0/0x30)
> >> [    2.770913] tps65218 0-0024: Failed to request IRQ 102 for tps65218: -22
> >> [    2.777854] tps65218: probe of 0-0024 failed with error -22
> > 
> > So does the tps65218 have some register to control the interrupt
> > direction or is it's datasheet wrong?
> > 
> > BTW, ADC might be a good test case for PMIC interrupt if it has one.
> 
> There is no ADC on this PMIC.
> 
> > 
> >> Use LEVEL_HIGH for the interrupt as it looks to be the correct setting:
> >> INTn of tps65218 is connected to NMIn of the SoC.
> >>
> >> The offending patches are only in linux-next.
> > 
> > OK

Applying these all into omap-for-v4.18/dt.

Regards,

Tony