linux-kernel - Re: [PATCH v1] lib/string_helpers: Add missed declaration of struct task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vdq48kv54noOJqnh29rpN30whBnOzA9-j4Y1dC4-XgLnA@mail.gmail.com>
Date:   Tue, 15 May 2018 21:54:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        James Morris <jmorris@...ei.org>
Subject: Re: [PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct

On Thu, May 10, 2018 at 11:59 PM, Kees Cook <keescook@...omium.org> wrote:
> On Thu, May 3, 2018 at 9:34 PM, Kees Cook <keescook@...omium.org> wrote:
>> On Thu, May 3, 2018 at 6:13 PM, Andy Shevchenko
>> <andriy.shevchenko@...ux.intel.com> wrote:
>>> Starting from the commit 0d0443288f22 the new function has been
>>> introduced which takes struct task_struct as a parameter. Though,
>>> compiler doesn't know where to get information about it at this stage.
>>>
>>> Add missed declaration of struct task_struct to satisfy compiler.
>>>
>>> Fixes: 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")
>>> Cc: Kees Cook <keescook@...omium.org>
>>> Cc: James Morris <james.l.morris@...cle.com>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> Acked-by: Kees Cook <keescook@...omium.org>
>>
>> I'm not sure who should carry this. You're welcome to put it in your tree?
>
> I haven't seen this show up in linux-next. Andy will you be taking it?

Will be in next next.

-- 
With Best Regards,
Andy Shevchenko