linux-kernel - Re: [PATCH] vsprintf: Fix memory barriers of ptr_key to have_filed_random_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwOoMHJaK5LmgmKKPvPUpTUBKSXS67cwaXwm2p-eG6ycQ@mail.gmail.com>
Date:   Tue, 15 May 2018 12:03:32 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        tcharding <me@...in.cc>
Subject: Re: [PATCH] vsprintf: Fix memory barriers of ptr_key to have_filed_random_ptr_key

On Tue, May 15, 2018 at 11:57 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> +       queue_work(system_unbound_wq, &enable_ptr_key_work);

I think this part just makes the whole thing entirely pointless.

Now the 'not_filled_random_ptr_key' thing won't actually take effect until
possibly much later, so all the work with making this work very early
during boot (when those works are *not* done) is all for naught.

Did I miss something?

              Linus