[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <31fe63a7a6497299dd2902fb15cc6346@codeaurora.org>
Date: Wed, 16 May 2018 14:13:25 -0700
From: Subhash Jadavani <subhashj@...eaurora.org>
To: Asutosh Das <asutoshd@...eaurora.org>
Cc: cang@...eaurora.org, vivek.gautam@...eaurora.org,
rnayak@...eaurora.org, vinholikatti@...il.com,
jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
linux-mmc@...r.kernel.org, linux-scsi@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH v2 07/10] scsi: ufs-qcom: remove broken hci version quirk
On 2018-05-03 04:07, Asutosh Das wrote:
> From: Subhash Jadavani <subhashj@...eaurora.org>
>
> UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS
> host
> controller version 2.x.y and this has been fixed from version 3.x.y
> onwards, hence this change removes this quirk for version 3.x.y
> onwards.
>
> Signed-off-by: Subhash Jadavani <subhashj@...eaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index d9edef8..27be327 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1103,7 +1103,7 @@ static void ufs_qcom_advertise_quirks(struct
> ufs_hba *hba)
> hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC;
> }
>
> - if (host->hw_ver.major >= 0x2) {
> + if (host->hw_ver.major == 0x2) {
> hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION;
> hba->quirks |= UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE;
> if (!ufs_qcom_cap_qunipro(host))
Looks good to me.
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Powered by blists - more mailing lists