[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180516062623.GA32694@kroah.com>
Date: Wed, 16 May 2018 08:26:23 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Alexey Dobriyan <adobriyan@...il.com>,
Lihao Liang <lianglihao@...wei.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Philippe Ombredanne <pombredanne@...b.com>,
Pekka Enberg <penberg@...nel.org>
Subject: Re: [PATCH 3/3] types: use fixed width types without
double-underscore prefix
On Wed, May 16, 2018 at 10:07:50AM +0900, Masahiro Yamada wrote:
> Hi Andrew,
>
> 2018-05-16 7:59 GMT+09:00 Andrew Morton <akpm@...ux-foundation.org>:
> > On Tue, 15 May 2018 11:22:05 +0900 Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> >
> >> This header file is not exported. It is safe to reference types
> >> without double-underscore prefix.
> >>
> >
> > It may be safe to do this, but why is it desirable?
>
>
> It is shorter. That's all.
> If it is a noise commit, please feel free to drop it.
>
>
> BTW, a large amount of kernel-space code
> uses underscore-prefixed types.
Sometimes it can/should do that.
> I wonder if we could check it by checkpatch.pl or something...
You do understand the difference between the two types and why/when they
are needed, right? I don't think checkpatch.pl can determine if data is
coming from userspace or not very easily to make this a simple perl
script check :(
thanks,
greg k-h
Powered by blists - more mailing lists