linux-kernel - Re: [PATCH 2/3] KVM: X86: Allow userspace to disable ioport intercept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+CxnSyenkV5ORjWkgtSG0uKvh0-hLRtvS-HPsZ3=PbCGvA@mail.gmail.com>
Date:   Wed, 16 May 2018 09:13:12 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Jim Mattson <jmattson@...gle.com>
Cc:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kvm list <kvm@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Tim Shearer <tshearer@...aoptical.com>,
        Liran Alon <liran.alon@...cle.com>
Subject: Re: [PATCH 2/3] KVM: X86: Allow userspace to disable ioport intercept

2018-05-16 5:56 GMT+08:00 Jim Mattson <jmattson@...gle.com>:
> I'd prefer to let the kvm module have the final say as to whether or
> not to allow userspace to do this.

I have an IRC discussion with Paolo, it seems that he didn't like the
original idea of the patchset.

Regards,
Wanpeng Li

>
> On Fri, May 11, 2018 at 8:43 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@...cle.com> wrote:
>> On Fri, May 11, 2018 at 11:42:46AM -0400, Konrad Rzeszutek Wilk wrote:
>>> On Mon, Apr 16, 2018 at 10:46:01PM -0700, Wanpeng Li wrote:
>>> > From: Wanpeng Li <wanpengli@...cent.com>
>>> >
>>> > Allow to disable ioport intercept by userspace.
>>> >
>>> > Cc: Paolo Bonzini <pbonzini@...hat.com>
>>> > Cc: Radim Krčmář <rkrcmar@...hat.com>
>>> > Cc: Tim Shearer <tshearer@...aoptical.com>
>>> > Cc: Liran Alon <liran.alon@...cle.com>
>>> > Signed-off-by: Wanpeng Li <wanpengli@...cent.com>
>>> > ---
>>> >  Documentation/virtual/kvm/api.txt | 11 +++++++++++
>>> >  arch/x86/include/asm/kvm_host.h   |  2 ++
>>> >  arch/x86/kvm/x86.c                |  5 +++++
>>> >  include/uapi/linux/kvm.h          |  1 +
>>> >  4 files changed, 19 insertions(+)
>>> >
>>> > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
>>> > index 1c7958b..3d0488e 100644
>>> > --- a/Documentation/virtual/kvm/api.txt
>>> > +++ b/Documentation/virtual/kvm/api.txt
>>> > @@ -4378,6 +4378,17 @@ all such vmexits.
>>> >
>>> >  Do not enable KVM_FEATURE_PV_UNHALT if you disable HLT exits.
>>> >
>>> > +7.14 KVM_CAP_IOPORT_DISABLE_INTERCEPT
>>> > +
>>> > +Architectures: x86
>>
>> And to be exact: Intel only..