linux-kernel - Re: [RESEND PATCH] clk: stm32: fix: stm32 clock drivers are not compiled by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a49b89ee-2aee-274d-ccc0-3eaf7d9a3755@st.com>
Date:   Wed, 16 May 2018 09:34:21 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        <gabriel.fernandez@...com>
CC:     <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        benjamin GAIGNARD <benjamin.gaignard@...com>,
        Loic PALLARDY <loic.pallardy@...com>
Subject: Re: [RESEND PATCH] clk: stm32: fix: stm32 clock drivers are not
 compiled by default



On 05/15/2018 11:48 PM, Stephen Boyd wrote:
> Quoting Alexandre Torgue (2018-05-14 05:45:57)
>>
>>
>> On 05/05/2018 04:45 AM, Stephen Boyd wrote:
>>> Quoting Alexandre Torgue (2018-05-04 00:54:16)
>>>> Stephen
>>>>
>>>> On 05/03/2018 08:40 AM, gabriel.fernandez@...com wrote:
>>>>> From: Gabriel Fernandez <gabriel.fernandez@...com>
>>>>>
>>>>> Clock driver is mandatory if the machine is selected.
>>>>> Then don't use 'bool' and 'depends on' commands, but 'def_bool'
>>>>> with the machine(s).
>>>>>
>>>>> Fixes: da32d3539fca ("clk: stm32: add configuration flags for each of the stm32 drivers")
>>>>>
>>>>
>>>> Sorry to insist but we need it to have STM32 MCUs booting on Kernel v4.17.
>>>
>>> Thanks for the bump. I missed this one. Of course, the user can still select
>>> the configs now, just it's annoying for upgrade path.
>>>
>>>>
>>>>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@...com>
>>>>> Acked-by: Alexandre TORGUE <alexandre.torgue@...com>
>>>>> ---
>>>>>     drivers/clk/Kconfig | 6 ++----
>>>>>     1 file changed, 2 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
>>>>> index 24a5bc3..721572a 100644
>>>>> --- a/drivers/clk/Kconfig
>>>>> +++ b/drivers/clk/Kconfig
>>>>> @@ -266,15 +266,13 @@ config COMMON_CLK_STM32MP157
>>>>>           Support for stm32mp157 SoC family clocks
>>>>>     
>>>>>     config COMMON_CLK_STM32F
>>>>> -     bool "Clock driver for stm32f4 and stm32f7 SoC families"
>>>>> -     depends on MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746
>>>>> +     def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746)
>>>
>>> But the point of the change this patch is fixing was to expose these to
>>> the user to turn off they wanted. You'll need to do something like that
>>> again here, instead of removing the prompt and replacing it with a
>>> def_bool.
>>>
>>
>> Sorry I don't understand. Clock driver is mandatory to boot each
>> platform and depends on machine type. Do you see a use case where we
>> could need to disable the clock driver? (it would impose to change
>> devicetree to use fixed clocks and to have a booloader which configures
>> all PLL and clocks).
> 
> No. My understanding of the patch that introduced the options was to
> allow the user to disable these drivers if they wanted to. I'm just
> reiterating the spirit of that patch. That must be wrong?
> 
Actually initial patch is a mistake. You can't boot STM32 platform 
without clock driver. This patch fixes that, and offers the possibility 
to not build the clock driver of the machine which are not used 
(currently all machine are selected but to reduce memory footprint you 
could disable not used machine in defconfig).