[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180516074333.i2672u435ymwffk3@verge.net.au>
Date: Wed, 16 May 2018 09:43:34 +0200
From: Simon Horman <horms@...ge.net.au>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Gilad Ben-Yossef <gilad@...yossef.com>,
Magnus Damm <magnus.damm@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Ofir Drang <ofir.drang@....com>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-clk <linux-clk@...r.kernel.org>,
Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding
On Tue, May 15, 2018 at 04:50:44PM +0200, Geert Uytterhoeven wrote:
> Hi Gilad,
>
> On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef <gilad@...yossef.com> wrote:
> > Add bindings for CryptoCell instance in the SoC.
> >
> > Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -528,6 +528,14 @@
> > status = "disabled";
> > };
> >
> > + arm_cc630p: crypto@...01000 {
> > + compatible = "arm,cryptocell-630p-ree";
> > + interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> > + #interrupt-cells = <2>;
>
> I believe the #interrupt-cells property is not needed.
>
> > + reg = <0x0 0xe6601000 0 0x1000>;
> > + clocks = <&cpg CPG_MOD 229>;
> > + };
>
> The rest looks good, but I cannot verify the register block.
>
> > +
> > i2c3: i2c@...d0000 {
> > #address-cells = <1>;
> > #size-cells = <0>;
Thanks, I have applied this after dropping the #interrupt-cells property.
Powered by blists - more mailing lists