[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20180516080312.rx6owusozklkmypj@black.fi.intel.com>
Date: Wed, 16 May 2018 11:03:12 +0300
From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To: "Huang, Ying" <ying.huang@...el.com>
Cc: "Kirill A. Shutemov" <kirill@...temov.name>,
Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org,
Andrea Arcangeli <aarcange@...hat.com>,
Andi Kleen <andi.kleen@...el.com>, Jan Kara <jack@...e.cz>,
Michal Hocko <mhocko@...e.com>,
Matthew Wilcox <mawilcox@...rosoft.com>,
Hugh Dickins <hughd@...gle.com>,
Minchan Kim <minchan@...nel.org>, Shaohua Li <shli@...com>,
Christopher Lameter <cl@...ux.com>,
"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
Punit Agrawal <punit.agrawal@....com>,
Anshuman Khandual <khandual@...ux.vnet.ibm.com>
Subject: Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler
On Wed, May 16, 2018 at 12:42:43AM +0000, Huang, Ying wrote:
> >> + unsigned long address = faddress & huge_page_mask(h);
> >
> > faddress? I would rather keep it address and rename maked out variable to
> > 'haddr'. We use 'haddr' for the cause in other places.
>
> I found haddr is popular in huge_memory.c but not used in hugetlb.c at
> all. Is it desirable to start to use "haddr" in hugetlb.c?
Yes, I think so. There's no reason to limit haddr convention to THP.
--
Kirill A. Shutemov
Powered by blists - more mailing lists