linux-kernel - Re: [PATCH] Makefile: disable PIE before testing asm goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516081635.GE12198@hirez.programming.kicks-ass.net>
Date:   Wed, 16 May 2018 10:16:35 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andreas Faerber <afaerber@...e.com>
Subject: Re: [PATCH] Makefile: disable PIE before testing asm goto

On Wed, May 16, 2018 at 07:51:36AM +0200, Michal Kubecek wrote:
> Since commit e501ce957a78 ("x86: Force asm-goto"), aarch64 build on
> distributions which enable PIE by default (e.g. openSUSE Tumbleweed) does
> not detect support for asm goto correctly. The problem is that ARM specific
> part of scripts/gcc-goto.sh fails with PIE even with recent gcc versions.
> Moving the asm goto detection up in Makefile put it before the place where
> we disable PIE. As a result, kernel is built without jump label support.

Ugh, that's nasty. Thanks for fixing that.

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>