[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180516085409.5u4hnes2dsfwwf5u@verge.net.au>
Date: Wed, 16 May 2018 10:54:14 +0200
From: Simon Horman <horms@...ge.net.au>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Jacopo Mondi <jacopo+renesas@...ndi.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
Linux Media Mailing List <linux-media@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0
On Wed, May 16, 2018 at 09:40:09AM +0200, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Thu, Apr 26, 2018 at 8:24 PM, Jacopo Mondi <jacopo+renesas@...ndi.org> wrote:
> > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Reported-by: Geert Uytterhoeven <geert@...der.be>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> Minor question below.
>
> > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > @@ -67,6 +67,16 @@
> > power-domains = <&pd_d4>;
> > };
> >
> > + ceu0: ceu@...10000 {
> > + reg = <0xfe910000 0x3000>;
> > + compatible = "renesas,r8a7740-ceu";
> > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp1_clks R8A7740_CLK_CEU20>;
> > + clock-names = "ceu20";
>
> Why the "clock-names" property? It's not mentioned in the DT bindings, and
> may cause issues if the bindings are ever amended.
I have dropped that property for now.
>
> > + power-domains = <&pd_a4r>;
> > + status = "disabled";
> > + };
> > +
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
Powered by blists - more mailing lists