linux-kernel - Re: [PATCH v2 05/14] tracing: Do not show filter file for ftrace internal events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516091025.GB30309@danjae.aot.lge.com>
Date:   Wed, 16 May 2018 18:10:25 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Clark Williams <williams@...hat.com>,
        Karim Yaghmour <karim.yaghmour@...rsys.com>,
        Brendan Gregg <bgregg@...flix.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Yann Ylavic <ylavic.dev@...il.com>,
        linux-rt-users@...r.kernel.org, kernel-team@....com
Subject: Re: [PATCH v2 05/14] tracing: Do not show filter file for ftrace
 internal events

On Mon, May 14, 2018 at 04:58:50PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> 
> The filter file in the ftrace internal events, like in
> /sys/kernel/tracing/events/ftrace/function/filter is not attached to any
> functionality. Do not create them as they are meaningless.
> 
> In the future, if an ftrace internal event gets filter functionality, then
> it will need to create it directly.
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> ---
>  kernel/trace/trace_events.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 5b647904a65b..14ff4ff3caab 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -2007,16 +2007,18 @@ event_create_dir(struct dentry *parent, struct trace_event_file *file)
>  			return -1;
>  		}
>  	}
> -	trace_create_file("filter", 0644, file->dir, file,
> -			  &ftrace_event_filter_fops);
>  
>  	/*
>  	 * Only event directories that can be enabled should have
> -	 * triggers.
> +	 * triggers or filters.
>  	 */
> -	if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE))
> +	if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) {
> +		trace_create_file("filter", 0644, file->dir, file,
> +				  &ftrace_event_filter_fops);
> +
>  		trace_create_file("trigger", 0644, file->dir, file,
>  				  &event_trigger_fops);
> +	}
>  
>  #ifdef CONFIG_HIST_TRIGGERS
>  	trace_create_file("hist", 0444, file->dir, file,

What about moving the "hist" file as well since it's meaningless
without the trigger.

Thanks,
Namhyung