linux-kernel - Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516095057.GG1972@nanopsycho>
Date:   Wed, 16 May 2018 11:50:57 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, pablo@...filter.org,
        kadlec@...ckhole.kfki.hu, fw@...len.de, ast@...nel.org,
        daniel@...earbox.net, edumazet@...gle.com, keescook@...omium.org,
        linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, kliteyn@...lanox.com
Subject: Re: [PATCH 13/14] net: sched: use unique idr insert function in
 unlocked actions

Mon, May 14, 2018 at 04:27:14PM CEST, vladbu@...lanox.com wrote:
>Substitute calls to action insert function with calls to action insert
>unique function that warns if insertion overwrites index in idr.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
>---
> net/sched/act_bpf.c        | 2 +-
> net/sched/act_connmark.c   | 2 +-
> net/sched/act_csum.c       | 2 +-
> net/sched/act_gact.c       | 2 +-
> net/sched/act_ife.c        | 2 +-
> net/sched/act_ipt.c        | 2 +-
> net/sched/act_mirred.c     | 2 +-
> net/sched/act_nat.c        | 2 +-
> net/sched/act_pedit.c      | 2 +-
> net/sched/act_police.c     | 2 +-
> net/sched/act_sample.c     | 2 +-
> net/sched/act_simple.c     | 2 +-
> net/sched/act_skbedit.c    | 2 +-
> net/sched/act_skbmod.c     | 2 +-
> net/sched/act_tunnel_key.c | 2 +-
> net/sched/act_vlan.c       | 2 +-
> 16 files changed, 16 insertions(+), 16 deletions(-)
>
>diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c
>index 7e20fdc..0bf4ecf 100644
>--- a/net/sched/act_bpf.c
>+++ b/net/sched/act_bpf.c
>@@ -354,7 +354,7 @@ static int tcf_bpf_init(struct net *net, struct nlattr *nla,
> 	rcu_assign_pointer(prog->filter, cfg.filter);
> 
> 	if (res == ACT_P_CREATED) {
>-		tcf_idr_insert(tn, *act);
>+		tcf_idr_insert_unique(tn, *act);

Seems to me that tcf_idr_insert() is unused after this patch. If that is
the case, I think that you don't need to introduce
tcf_idr_insert_unique() and just do what you need to do in
tcf_idr_insert()

[...]