linux-kernel - Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516095802.GA16090@kroah.com>
Date:   Wed, 16 May 2018 11:58:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-rtc@...r.kernel.org, Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
        jfs-discussion@...ts.sourceforge.net,
        linux-afs@...ts.infradead.org, linux-acpi@...r.kernel.org,
        netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        Jiri Slaby <jslaby@...e.com>, linux-ext4@...r.kernel.org,
        Alexey Dobriyan <adobriyan@...il.com>,
        megaraidlinux.pdl@...adcom.com, drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show

On Wed, May 16, 2018 at 11:43:45AM +0200, Christoph Hellwig wrote:
> Just set up the show callback in the tty_operations, and use
> proc_create_single_data to create the file without additional
> boilerplace code.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>