linux-kernel - Re: [PATCH v2 05/14] tracing: Do not show filter file for ftrace internal events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516064425.6cdd45e1@gandalf.local.home>
Date:   Wed, 16 May 2018 06:44:25 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Clark Williams <williams@...hat.com>,
        Karim Yaghmour <karim.yaghmour@...rsys.com>,
        Brendan Gregg <bgregg@...flix.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Yann Ylavic <ylavic.dev@...il.com>,
        linux-rt-users@...r.kernel.org, kernel-team@....com
Subject: Re: [PATCH v2 05/14] tracing: Do not show filter file for ftrace
 internal events

On Wed, 16 May 2018 18:10:25 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

  
> >  	/*
> >  	 * Only event directories that can be enabled should have
> > -	 * triggers.
> > +	 * triggers or filters.
> >  	 */
> > -	if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE))
> > +	if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) {
> > +		trace_create_file("filter", 0644, file->dir, file,
> > +				  &ftrace_event_filter_fops);
> > +
> >  		trace_create_file("trigger", 0644, file->dir, file,
> >  				  &event_trigger_fops);
> > +	}
> >  
> >  #ifdef CONFIG_HIST_TRIGGERS
> >  	trace_create_file("hist", 0444, file->dir, file,  
> 
> What about moving the "hist" file as well since it's meaningless
> without the trigger.

I thought about doing this too. But when I had to manually create the
trigger file, I'll have to also manually create the hist file. As the
hist file is read only and rather harmless, I figured I'd just leave it
as is. The filter file is a command file and this patch wants to remove
the confusion of writing into the file and having no effect.

-- Steve